Source/modules/serviceworkers/ExtendableEvent.h - Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method.

Side by Side Diff: Source/modules/serviceworkers/ExtendableEvent.h

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42	42

43 class MODULES_EXPORT ExtendableEvent : public Event {	43 class MODULES_EXPORT ExtendableEvent : public Event {

44 DEFINE_WRAPPERTYPEINFO();	44 DEFINE_WRAPPERTYPEINFO();

45 public:	45 public:

46 static PassRefPtrWillBeRawPtr<ExtendableEvent> create();	46 static PassRefPtrWillBeRawPtr<ExtendableEvent> create();

47 static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& ty pe, const ExtendableEventInit&);	47 static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& ty pe, const ExtendableEventInit&);

48 static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& ty pe, const ExtendableEventInit&, WaitUntilObserver*);	48 static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& ty pe, const ExtendableEventInit&, WaitUntilObserver*);

49	49

50 ~ExtendableEvent() override;	50 ~ExtendableEvent() override;

51	51

52 void waitUntil(ScriptState*, const ScriptValue&, ExceptionState&);	52 void waitUntil(ScriptState*, ScriptPromise&, ExceptionState&);
	yhirano 2015/07/27 12:21:24 Can you use \|ScriptPromise\| instead of \|ScriptProm Can you use \|ScriptPromise\| instead of \|ScriptPromise&\|? jungkees 2015/07/27 12:37:49 Sure, but could you explain why? Both scriptPromis Sure, but could you explain why? Both scriptPromise and exceptionState are passed references. Is there any case where the object created in V8 layer destroyed before the object passed to Blink layer? If it should, I'll probably have to change the same for FetchEvent.respondWith code where I used references. Thanks! yhirano 2015/07/27 12:45:32 ScriptPromise is a value and copying it is not exp Show quoted text On 2015/07/27 12:37:49, jungkees wrote: > Sure, but could you explain why? Both scriptPromise and exceptionState are > passed references. Is there any case where the object created in V8 layer > destroyed before the object passed to Blink layer? If it should, I'll probably > have to change the same for FetchEvent.respondWith code where I used references. > Thanks! ScriptPromise is a value and copying it is not expensive. I would rather use value than non-const reference in such cases. ExceptionState is different: It is not copyable, and that non-const reference intends to update the state. I'm sorry I overlooked the point in the last CL. jungkees 2015/07/27 14:23:33 Agreed. Thanks for the explanation! Show quoted text On 2015/07/27 12:45:32, yhirano wrote: > ScriptPromise is a value and copying it is not expensive. I would rather use > value than non-const reference in such cases. ExceptionState is different: It is > not copyable, and that non-const reference intends to update the state. > Agreed. Thanks for the explanation! Show quoted text > I'm sorry I overlooked the point in the last CL. I'll address this point there too.
53	53

54 const AtomicString& interfaceName() const override;	54 const AtomicString& interfaceName() const override;

55 DECLARE_VIRTUAL_TRACE();	55 DECLARE_VIRTUAL_TRACE();

56	56

57 protected:	57 protected:

58 ExtendableEvent();	58 ExtendableEvent();

59 ExtendableEvent(const AtomicString& type, const ExtendableEventInit&);	59 ExtendableEvent(const AtomicString& type, const ExtendableEventInit&);

60 ExtendableEvent(const AtomicString& type, const ExtendableEventInit&, WaitUn tilObserver*);	60 ExtendableEvent(const AtomicString& type, const ExtendableEventInit&, WaitUn tilObserver*);

61	61

62 PersistentWillBeMember<WaitUntilObserver> m_observer;	62 PersistentWillBeMember<WaitUntilObserver> m_observer;

63 };	63 };

64	64

65 } // namespace blink	65 } // namespace blink

66	66

67 #endif // ExtendableEvent_h	67 #endif // ExtendableEvent_h

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ExtendableEvent.cpp » ('j') | Source/modules/serviceworkers/WaitUntilObserver.h » ('J')