Source/modules/serviceworkers/WaitUntilObserver.h - Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 1256133002: Service Worker: Correct Web IDL of ExtendableEvent.waitUntil method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename method params. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ExtendableEvent.h ('K') | « Source/modules/serviceworkers/ExtendableEvent.idl ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/WaitUntilObserver.h

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.h b/Source/modules/serviceworkers/WaitUntilObserver.h

index 30fe525fa90923c355a8c7e74b5b1715682ecb3a..fbb63e3250c8ea33e6ec0cbd9b11a9aee2e4728a 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.h

+++ b/Source/modules/serviceworkers/WaitUntilObserver.h

@@ -16,6 +16,7 @@ namespace blink {

class ExceptionState;

class ExecutionContext;

+class ScriptPromise;

class ScriptState;

class ScriptValue;

@@ -39,7 +40,7 @@ public:

// Observes the promise and delays calling the continuation until

// the given promise is resolved or rejected.

- void waitUntil(ScriptState*, const ScriptValue&, ExceptionState&);

+ void waitUntil(ScriptState*, ScriptPromise&, ExceptionState&);

yhirano 2015/07/27 12:21:24 Can you use |ScriptPromise| instead of |ScriptProm

DECLARE_VIRTUAL_TRACE();