Reference written files relatively when possible.

Reference written files relatively when possible.

The intermediately generated files are children of the output build
directory and shouldn't need long absolute path references that
change more often than necessary.

BUG=49621
TEST=Equivalence of build files, see https://code.google.com/p/chromium/issues/detail?id=469621#c3

Committed: https://crrev.com/d79f1ac6d572f795fd8e2522fe4a731d1f66260c
Cr-Commit-Position: refs/heads/master@{#341768}

[Peter Mayo, 2015-07-31 01:57:13]

petermayo@chromium.org changed reviewers:
+ dpranke@chromium.org

[Peter Mayo, 2015-07-31 01:57:14]

WDYT?

[Dirk Pranke, 2015-07-31 19:03:54]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2015-07-31 19:03:54]

This looks plausible to me, but Brett should review it. I have a few questions,
but let's see what he says instead.

[Peter Mayo, 2015-07-31 19:08:07]

https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer.cc
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:166:
written_file.Resolve(build_settings_->root_path()), path_escaping);
Oops, forgot to change to UTF8.

[brettw, 2015-07-31 23:36:55]

https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer.cc
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:159: base::FilePath::StringType fileref =
ComputeStringInOutputDir(
I think RebasePath in filesystem_utils.h will handle all cases of converting a
SourceFile string to be relative to a given directory. If not, we should fix it.

[Peter Mayo, 2015-07-31 23:49:26]

Simplify to use RebasePath

[Peter Mayo, 2015-07-31 23:55:35]

Patchset #3 (id:40001) has been deleted

[Peter Mayo, 2015-07-31 23:57:42]

Re-add escaping, drop line

[Peter Mayo, 2015-08-01 00:01:58]

On 2015/07/31 23:36:55, brettw wrote:
>
https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer.cc
> File tools/gn/ninja_build_writer.cc (right):
> 
>
https://codereview.chromium.org/1256043006/diff/1/tools/gn/ninja_build_writer...
> tools/gn/ninja_build_writer.cc:159: base::FilePath::StringType fileref =
> ComputeStringInOutputDir(
> I think RebasePath in filesystem_utils.h will handle all cases of converting a
> SourceFile string to be relative to a given directory. If not, we should fix
it.

Good call, I can't remember now why I ruled it out earlier, but what it came
back around to 
fits the definition just fine.

(IIRC I spent some time doing the normalization in the function_write_file,
where the validation gets called, and redoing it seemed wasteful)


PTAL

[brettw, 2015-08-01 20:18:53]

That was short! LGTM

[Peter Mayo, 2015-08-04 13:48:06]

The CQ bit was checked by petermayo@chromium.org

[commit-bot: I haz the power, 2015-08-04 13:48:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256043006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256043006/60001

[commit-bot: I haz the power, 2015-08-04 13:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 13:59:18]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Peter Mayo, 2015-08-04 17:29:44]

More windows type fixing

[Peter Mayo, 2015-08-04 19:12:36]

More windows type fixing

[Peter Mayo, 2015-08-04 19:36:48]

The CQ bit was checked by petermayo@chromium.org

[Peter Mayo, 2015-08-04 19:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1256043006/#ps120001
(title: "More windows type fixing")

[commit-bot: I haz the power, 2015-08-04 19:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256043006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256043006/120001

[Peter Mayo, 2015-08-04 19:43:26]

PTAL to make sure you are OK about where the conversions to UTF8 went.  I ended
up using similar code in ninja_target_writer.cc as a precedent.

I chose not to extend path_output to handle the case of outputing lists of
SourceFiles like it does OutputFiles today.

[commit-bot: I haz the power, 2015-08-04 19:54:10]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-08-04 19:56:01]

Patchset 6 (id:??) landed as
https://crrev.com/d79f1ac6d572f795fd8e2522fe4a731d1f66260c
Cr-Commit-Position: refs/heads/master@{#341768}