Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/ninja_build_writer.cc

Issue 1256043006: Reference written files relatively when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More windows type fixing Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.cc
diff --git a/tools/gn/ninja_build_writer.cc b/tools/gn/ninja_build_writer.cc
index 12a37e13d8b5eaa735339b37a8ebed52b47fb670..43916763db56231856526a099441e7b9d7b1cbdc 100644
--- a/tools/gn/ninja_build_writer.cc
+++ b/tools/gn/ninja_build_writer.cc
@@ -154,9 +154,9 @@ void NinjaBuildWriter::WriteNinjaRules() {
path_escaping.mode = ESCAPE_NINJA_COMMAND;
std::vector<SourceFile> written_files = g_scheduler->GetWrittenFiles();
for (const auto& written_file : written_files)
- out_ << " " <<
- EscapeString(FilePathToUTF8(build_settings_->GetFullPath(written_file)),
- path_escaping, nullptr);
+ out_ << " " << EscapeString(RebasePath(written_file.value(),
+ build_settings_->build_dir(), build_settings_->root_path_utf8()),
+ path_escaping, nullptr);
out_ << ": gn\n"
<< " generator = 1\n"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698