Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1255813002: Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (patchset #1 id:1 of https://codereview.chromium.org/1203953002/) Reason for revert: This shipped new prefixed APIs: https://groups.google.com/a/chromium.org/d/msg/blink-dev/htsW078UcFA/2cel1auAH60J Original issue's description: > Enable ServiceWorkerPerformanceTimeline flag for stable > > This ships User Timing and Resource Timing in Workers, and workerStart > attribute of Resource Timing. > > I think it's safe to enable it now; User Timing and workerStart have > landed over 2 weeks ago. Resource Timing part is new, but I only added > main thread to worker plumbing on the existing stable implementation. > > Intent to Implement and Ship: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA > > BUG=465640, 465641, 465643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197722 BUG=465640, 465641, 465643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
philipj_slow
Created Revert of Enable ServiceWorkerPerformanceTimeline flag for stable
5 years, 5 months ago (2015-07-24 06:50:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255813002/1
5 years, 5 months ago (2015-07-24 06:53:34 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 06:58:27 UTC) #5
Dry run: Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/63855)

Powered by Google App Engine
This is Rietveld 408576698