Remove a race around NetworkChangeNotifier::test_notifications_only_

Remove a race around NetworkChangeNotifier::test_notifications_only_

There is a possible race in which
NetworkChangeNotifier::test_notifications_only_ might be read on one
thread while being written on another. This CL fixes that by making
the variable static and only allowing writes to it before the
NetworkChangeNotifier is created (before other things might try to
read it).

BUG=454652
Committed: https://crrev.com/e160f6be485deabcb4725d7e3623ae18ef5aee48
Cr-Commit-Position: refs/heads/master@{#341354}

[jkarlin, 2015-07-27 17:55:25]

jkarlin@chromium.org changed reviewers:
+ pauljensen@chromium.org

[jkarlin, 2015-07-27 17:55:25]

paul: PTAL at net/, thanks!

[pauljensen, 2015-07-27 18:20:23]

data_reduction_proxy_bypass_protocol_unittest.cc and maybe another spot look
like they initialize an NCN before calling SetTestOnly...().
Golly I dislike statics...I imagine there isn't an easy way to get this passed
into the NCN constructor is there?

[jkarlin, 2015-07-27 18:38:53]

On 2015/07/27 18:20:23, pauljensen wrote:
> data_reduction_proxy_bypass_protocol_unittest.cc and maybe another spot look
> like they initialize an NCN before calling SetTestOnly...().
> Golly I dislike statics...I imagine there isn't an easy way to get this passed
> into the NCN constructor is there?

Tests should be fixed, rerunning now.

Adding it to the constructor looks pretty painful.

[pauljensen, 2015-07-28 11:40:35]

Doesn't build on ChromeOS.

[jkarlin, 2015-07-28 13:00:54]

On 2015/07/28 11:40:35, pauljensen wrote:
> Doesn't build on ChromeOS.

Thanks for looking. Fixed.

[jkarlin, 2015-07-28 13:02:15]

On 2015/07/28 13:00:54, jkarlin wrote:
> On 2015/07/28 11:40:35, pauljensen wrote:
> > Doesn't build on ChromeOS.
> 
> Thanks for looking. Fixed.

Looking into ios_dbg_simulator_ninja

[jkarlin, 2015-07-28 14:33:12]

Patchset #6 (id:100001) has been deleted

[jkarlin, 2015-07-28 16:56:05]

Should be good for review again.

[pauljensen, 2015-07-28 18:45:11]

lgtm

[jkarlin, 2015-07-28 18:52:15]

jkarlin@chromium.org changed reviewers:
+ asvitkine@chromium.org, bengr@chromium.org, jochen@chromium.org,
yoshiki@chromium.org

[jkarlin, 2015-07-28 18:52:16]

Thanks Paul!

asvitkine@chromium.org: Please review changes in components/web_resource/

bengr@chromium.org: Please review changes in data_reduction_proxy/

yoshiki@chromium.org: Please review changes in 
browser/chromeos/

jochen@chromium.org: Please review changes in net_info_browsertest (note that
I'm the primary author of this file)

[Alexei Svitkine (slow), 2015-07-28 19:54:54]

lgtm

[jochen (gone - plz use gerrit), 2015-07-29 11:41:40]

lgtm

[yoshiki, 2015-07-30 01:47:28]

file_manager lgtm

[jkarlin, 2015-07-30 12:54:55]

bengr: PTAL, thanks!

[bengr, 2015-07-31 15:37:08]

data_reduction_proxy lgtm

[jkarlin, 2015-07-31 15:38:38]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2015-07-31 15:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1255263002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1255263002/120001

[commit-bot: I haz the power, 2015-07-31 17:04:16]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-07-31 17:04:54]

Patchset 6 (id:??) landed as
https://crrev.com/e160f6be485deabcb4725d7e3623ae18ef5aee48
Cr-Commit-Position: refs/heads/master@{#341354}