components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 1255263002: Remove a race around NetworkChangeNotifier::test_notifications_only_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 1255263002: Remove a race around NetworkChangeNotifier::test_notifications_only_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Possible iOS fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc ('k') | components/web_resource/resource_request_allowed_notifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 2dd5da25802fedefa04f410b363fad746d0ab997..e38a603a49c867a91959612863f508aa156f0423 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -85,9 +85,9 @@ class DataReductionProxyProtocolTest : public testing::Test {

}

void SetUp() override {

+ net::NetworkChangeNotifier::SetTestNotificationsOnly(true);

test_context_ = DataReductionProxyTestContext::Builder().Build();

network_change_notifier_.reset(net::NetworkChangeNotifier::CreateMock());

- net::NetworkChangeNotifier::SetTestNotificationsOnly(true);

test_context_->RunUntilIdle();

}