components/web_resource/resource_request_allowed_notifier_unittest.cc - Issue 1255263002: Remove a race around NetworkChangeNotifier::test_notifications_only_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_resource/resource_request_allowed_notifier_unittest.cc

Issue 1255263002: Remove a race around NetworkChangeNotifier::test_notifications_only_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Possible iOS fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc ('k') | content/browser/net_info_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_resource/resource_request_allowed_notifier_unittest.cc

diff --git a/components/web_resource/resource_request_allowed_notifier_unittest.cc b/components/web_resource/resource_request_allowed_notifier_unittest.cc

index 27905628ccb686bee15ae95a2087cadde70984a2..3383c8b58bcb2d1fc253ef8619752cd777c0b2c1 100644

--- a/components/web_resource/resource_request_allowed_notifier_unittest.cc

+++ b/components/web_resource/resource_request_allowed_notifier_unittest.cc

@@ -23,7 +23,8 @@ class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {

void SimulateNetworkConnectionChange(

net::NetworkChangeNotifier::ConnectionType type) {

connection_type_to_return_ = type;

- net::NetworkChangeNotifier::NotifyObserversOfConnectionTypeChange();

+ net::NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(

+ connection_type_to_return_);

base::MessageLoop::current()->RunUntilIdle();

}