Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 12543006: Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall. (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, kareng
Visibility:
Public.

Description

Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall. remoting_host_installation uses lots of non-trivial GYP that tend to break because of differences between ninja and msbuild. Building it on the main waterfall gives us an early warning if something goes wrong. BUG=180600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186522

Patch Set 1 #

Patch Set 2 : Build the installer even if component build is used. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M build/all.gyp View 1 1 chunk +28 lines, -19 lines 0 comments Download
M remoting/remoting.gyp View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 9 months ago (2013-03-06 17:56:08 UTC) #1
Jamie
lgtm
7 years, 9 months ago (2013-03-06 19:39:19 UTC) #2
alexeypa (please no reviews)
+Karen for awareness.
7 years, 9 months ago (2013-03-06 20:31:44 UTC) #3
alexeypa (please no reviews)
7 years, 9 months ago (2013-03-06 22:39:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r186522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698