Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: build/all.gyp

Issue 12543006: Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build the installer even if component build is used. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/remoting.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/all.gyp
diff --git a/build/all.gyp b/build/all.gyp
index dfc381116eeb161b16f200b05233d9b70196588d..cb84dce3ff80b946e49335064eb865de5d2f0be4 100644
--- a/build/all.gyp
+++ b/build/all.gyp
@@ -248,25 +248,34 @@
'../ui/app_list/app_list.gyp:app_list_unittests',
'../ui/views/views.gyp:views_unittests',
'../webkit/webkit.gyp:test_shell_common',
- ],
- 'conditions': [
- ['target_arch!="x64"', {
- 'dependencies': [
- '../chrome_frame/chrome_frame.gyp:chrome_frame_net_tests',
- '../chrome_frame/chrome_frame.gyp:chrome_frame_perftests',
- '../chrome_frame/chrome_frame.gyp:chrome_frame_reliability_tests',
- '../chrome_frame/chrome_frame.gyp:chrome_frame_tests',
- '../chrome_frame/chrome_frame.gyp:chrome_frame_unittests',
- ]
- }, { # target_arch!="x64"
- 'dependencies!': [
- '../chrome_frame/chrome_frame.gyp:npchrome_frame',
- ],
- 'defines': [
- 'OMIT_CHROME_FRAME',
- ],
- }], # target_arch=="x64"
- ],
+ ],
+ 'conditions': [
+ ['target_arch!="x64"', {
+ 'dependencies': [
+ '../chrome_frame/chrome_frame.gyp:chrome_frame_net_tests',
+ '../chrome_frame/chrome_frame.gyp:chrome_frame_perftests',
+ '../chrome_frame/chrome_frame.gyp:chrome_frame_reliability_tests',
+ '../chrome_frame/chrome_frame.gyp:chrome_frame_tests',
+ '../chrome_frame/chrome_frame.gyp:chrome_frame_unittests',
+ ]
+ }, { # target_arch!="x64"
+ 'dependencies!': [
+ '../chrome_frame/chrome_frame.gyp:npchrome_frame',
+ ],
+ 'defines': [
+ 'OMIT_CHROME_FRAME',
+ ],
+ }], # target_arch=="x64"
+ # remoting_host_installation uses lots of non-trivial GYP that tend
+ # to break because of differences between ninja and msbuild. Make
+ # sure this target is built by the builders on the main waterfall.
+ # See http://crbug.com/180600.
+ ['wix_exists == "True" and sas_dll_exists == "True"', {
+ 'dependencies': [
+ '../remoting/remoting.gyp:remoting_host_installation',
+ ],
+ }],
+ ],
}],
['OS=="linux"', {
'dependencies': [
« no previous file with comments | « no previous file | remoting/remoting.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698