Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: remoting/remoting.gyp

Issue 12543006: Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build the installer even if component build is used. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting.gyp
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp
index eb4ce4affd1ff1c7dd41a52d2fceb013d4198e0e..476815b74c8d999b8d7e735b24824b283b8108b5 100644
--- a/remoting/remoting.gyp
+++ b/remoting/remoting.gyp
@@ -1668,12 +1668,11 @@
], # end of 'targets'
}], # 'OS=="win"'
- # The host installation is generated only if WiX is available and when
- # building a non-component build. WiX does not provide a easy way to
- # include all DLLs imported by the installed binaries, so supporting
- # the component build becomes a burden.
- ['OS == "win" and component != "shared_library" and wix_exists == "True" \
- and sas_dll_exists == "True"', {
+ # The host installation is generated only if WiX is available. If
+ # component build is used the produced installation will not work due to
+ # missing DLLs. We build it anyway to make sure the GYP scripts are executed
+ # by the bots.
+ ['OS == "win" and wix_exists == "True" and sas_dll_exists == "True"', {
'targets': [
{
'target_name': 'remoting_host_installation',
« no previous file with comments | « build/all.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698