Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chromecast/crash/BUILD.gn

Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Updated commit message Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/BUILD.gn
diff --git a/chromecast/crash/BUILD.gn b/chromecast/crash/BUILD.gn
index d085b353730c1e8bbf607ba0c8bdaf8dfa1ef27c..beb0ccbec3909bf24325320035ba5bd02a69f9a6 100644
--- a/chromecast/crash/BUILD.gn
+++ b/chromecast/crash/BUILD.gn
@@ -37,6 +37,18 @@ source_set("crash") {
]
}
+source_set("cast_crash_test_support") {
slan 2015/07/28 23:50:30 nit: GN convention here is just "test_support"
bcf_google 2015/07/29 00:41:13 Done.
+ sources = [
+ "linux/crash_testing_utils.cc",
+ "linux/crash_testing_utils.h",
+ ]
+
+ deps = [
+ ":crash",
+ "//base",
+ ]
+}
+
test("cast_crash_unittests") {
sources = [
"cast_crashdump_uploader_unittest.cc",
@@ -48,6 +60,7 @@ test("cast_crash_unittests") {
deps = [
":crash",
+ ":cast_crash_test_support",
slan 2015/07/28 23:50:30 nit: lexi ordering
bcf_google 2015/07/29 00:41:13 Done.
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",

Powered by Google App Engine
This is Rietveld 408576698