Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Side by Side Diff: chromecast/crash/BUILD.gn

Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Updated commit message Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 source_set("crash") { 7 source_set("crash") {
8 sources = [ 8 sources = [
9 "app_state_tracker.cc", 9 "app_state_tracker.cc",
10 "app_state_tracker.h", 10 "app_state_tracker.h",
(...skipping 19 matching lines...) Expand all
30 configs += [ "//chromecast:config" ] 30 configs += [ "//chromecast:config" ]
31 31
32 deps = [ 32 deps = [
33 "//base", 33 "//base",
34 "//breakpad:client", 34 "//breakpad:client",
35 "//chromecast/base", 35 "//chromecast/base",
36 "//chromecast/base:cast_version", 36 "//chromecast/base:cast_version",
37 ] 37 ]
38 } 38 }
39 39
40 source_set("cast_crash_test_support") {
slan 2015/07/28 23:50:30 nit: GN convention here is just "test_support"
bcf_google 2015/07/29 00:41:13 Done.
41 sources = [
42 "linux/crash_testing_utils.cc",
43 "linux/crash_testing_utils.h",
44 ]
45
46 deps = [
47 ":crash",
48 "//base",
49 ]
50 }
51
40 test("cast_crash_unittests") { 52 test("cast_crash_unittests") {
41 sources = [ 53 sources = [
42 "cast_crashdump_uploader_unittest.cc", 54 "cast_crashdump_uploader_unittest.cc",
43 "linux/dummy_minidump_generator_unittest.cc", 55 "linux/dummy_minidump_generator_unittest.cc",
44 "linux/dump_info_unittest.cc", 56 "linux/dump_info_unittest.cc",
45 "linux/minidump_writer_unittest.cc", 57 "linux/minidump_writer_unittest.cc",
46 "linux/synchronized_minidump_manager_unittest.cc", 58 "linux/synchronized_minidump_manager_unittest.cc",
47 ] 59 ]
48 60
49 deps = [ 61 deps = [
50 ":crash", 62 ":crash",
63 ":cast_crash_test_support",
slan 2015/07/28 23:50:30 nit: lexi ordering
bcf_google 2015/07/29 00:41:13 Done.
51 "//base", 64 "//base",
52 "//base/test:run_all_unittests", 65 "//base/test:run_all_unittests",
53 "//base/test:test_support", 66 "//base/test:test_support",
54 "//breakpad:client", 67 "//breakpad:client",
55 "//testing/gmock", 68 "//testing/gmock",
56 "//testing/gtest", 69 "//testing/gtest",
57 ] 70 ]
58 } 71 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698