chromecast/chromecast_tests.gypi - Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/chromecast_tests.gypi

Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Updated commit message Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/chromecast_tests.gypi

diff --git a/chromecast/chromecast_tests.gypi b/chromecast/chromecast_tests.gypi

index 96897e26285dd5dca7738eeb722fa0ba7066c080..075734addbd1923919f76e64585c55423856cc2e 100644

--- a/chromecast/chromecast_tests.gypi

+++ b/chromecast/chromecast_tests.gypi

@@ -30,9 +30,22 @@

}, # end of cast_base_unittests

{

+ 'target_name': 'cast_crash_test_support',

+ 'type': '<(component)',

+ 'dependencies': [

+ 'chromecast.gyp:cast_crash',

+ 'cast_base',

+ ],

+ 'sources': [

+ 'crash/linux/crash_testing_utils.cc',

+ 'crash/linux/crash_testing_utils.h',

+ ],

+ }, # end of target 'cast_crash_test_support'

+ {

'target_name': 'cast_crash_unittests',

'type': '<(gtest_target_type)',

'dependencies': [

+ 'cast_crash_test_support',

'chromecast.gyp:cast_crash',

'../base/base.gyp:run_all_unittests',

'../testing/gmock.gyp:gmock',

@@ -330,6 +343,7 @@

'target_name': 'cast_shell_unittests',

'type': '<(gtest_target_type)',

'dependencies': [

+ 'cast_crash_test_support',

'chromecast.gyp:cast_crash_client',

'../base/base.gyp:run_all_unittests',

'../testing/gtest.gyp:gtest',

« no previous file with comments | « chromecast/app/linux/cast_crash_reporter_client_unittest.cc ('k') | chromecast/crash/BUILD.gn » ('j') | chromecast/crash/BUILD.gn » ('J')