Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6082)

Unified Diff: chromecast/app/linux/cast_crash_reporter_client_unittest.cc

Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Updated commit message Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/app/linux/cast_crash_reporter_client_unittest.cc
diff --git a/chromecast/app/linux/cast_crash_reporter_client_unittest.cc b/chromecast/app/linux/cast_crash_reporter_client_unittest.cc
index e37e4dfdb646eb2fa157be8e4bfa2036e6698bc7..adcfd26cb94d90ebdb36f855a37649465cf2f37e 100644
--- a/chromecast/app/linux/cast_crash_reporter_client_unittest.cc
+++ b/chromecast/app/linux/cast_crash_reporter_client_unittest.cc
@@ -13,8 +13,8 @@
#include "base/threading/thread_restrictions.h"
#include "base/values.h"
#include "chromecast/app/linux/cast_crash_reporter_client.h"
-#include "chromecast/base/serializers.h"
#include "chromecast/crash/app_state_tracker.h"
+#include "chromecast/crash/linux/crash_testing_utils.h"
#include "chromecast/crash/linux/crash_util.h"
#include "chromecast/crash/linux/dump_info.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -24,7 +24,6 @@ namespace {
const char kFakeDumpstateContents[] = "Dumpstate Contents\nDumpdumpdumpdump\n";
const char kFakeMinidumpContents[] = "Minidump Contents\nLine1\nLine2\n";
-const char kDumpsKey[] = "dumps";
int WriteFakeDumpStateFile(const std::string& path) {
// Append the correct extension and write the data to file.
@@ -35,34 +34,6 @@ int WriteFakeDumpStateFile(const std::string& path) {
return 0;
}
-bool FetchDumps(const std::string& lockfile_path,
- ScopedVector<DumpInfo>* dumps) {
- if (!dumps) {
- return false;
- }
- dumps->clear();
-
- base::FilePath path(lockfile_path);
- scoped_ptr<base::Value> contents(DeserializeJsonFromFile(path));
-
- base::DictionaryValue* dict;
- base::ListValue* dump_list;
- if (!contents || !contents->GetAsDictionary(&dict) ||
- !dict->GetList(kDumpsKey, &dump_list) || !dump_list) {
- return false;
- }
-
- for (base::Value* elem : *dump_list) {
- scoped_ptr<DumpInfo> dump = make_scoped_ptr(new DumpInfo(elem));
- if (!dump->valid()) {
- return false;
- }
- dumps->push_back(dump.Pass());
- }
-
- return true;
-}
-
} // namespace
class CastCrashReporterClientTest : public testing::Test {

Powered by Google App Engine
This is Rietveld 408576698