[Chromecast] Consolidate duplicated crash test functions.

[Chromecast] Consolidate duplicated crash test functions.

TEST=Modified tests build and pass under gyp and gn.
BUG=

Committed: https://crrev.com/62f6287af58fa80a2b830e436ea4f8dd20b8e1d5
Cr-Commit-Position: refs/heads/master@{#340924}

[bcf_google, 2015-07-28 23:41:17]

bcf@google.com changed reviewers:
+ gunsch@chromium.org, slan@chromium.org

[slan, 2015-07-28 23:50:31]

Just nits.

Thank you for taking the time to do this!

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD.gn
File chromecast/crash/BUILD.gn (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD....
chromecast/crash/BUILD.gn:40: source_set("cast_crash_test_support") {
nit:

GN convention here is just "test_support"

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD....
chromecast/crash/BUILD.gn:63: ":cast_crash_test_support",
nit: lexi ordering

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/crash_testing_utils.cc (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/crash_testing_utils.cc:93: }  // chromecast
nit: namespace chromecast

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/crash_testing_utils.h (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/crash_testing_utils.h:15: scoped_ptr<DumpInfo>
CreateDumpInfo(const std::string& json_string);
Please put brief comments detailing |inputs| and return values. Doesn't have to
be crazy verbose, just enough to prevent the need to visit .cc

[gunsch, 2015-07-29 00:19:18]

lgtm % resolving slan's comments

[bcf_google, 2015-07-29 00:41:13]

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD.gn
File chromecast/crash/BUILD.gn (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD....
chromecast/crash/BUILD.gn:40: source_set("cast_crash_test_support") {
On 2015/07/28 23:50:30, slan wrote:
> nit:
> 
> GN convention here is just "test_support"

Done.

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/BUILD....
chromecast/crash/BUILD.gn:63: ":cast_crash_test_support",
On 2015/07/28 23:50:30, slan wrote:
> nit: lexi ordering

Done.

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/crash_testing_utils.cc (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/crash_testing_utils.cc:93: }  // chromecast
On 2015/07/28 23:50:30, slan wrote:
> nit: namespace chromecast

Done.

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/crash_testing_utils.h (right):

https://codereview.chromium.org/1254113004/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/crash_testing_utils.h:15: scoped_ptr<DumpInfo>
CreateDumpInfo(const std::string& json_string);
On 2015/07/28 23:50:30, slan wrote:
> Please put brief comments detailing |inputs| and return values. Doesn't have
to
> be crazy verbose, just enough to prevent the need to visit .cc

Done.

[bcf_google, 2015-07-29 00:43:58]

The CQ bit was checked by bcf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 00:44:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254113004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254113004/60001

[slan, 2015-07-29 00:46:12]

lgtm

1 more nit. Thanks again.

https://codereview.chromium.org/1254113004/diff/60001/chromecast/crash/linux/...
File chromecast/crash/linux/dump_info_unittest.cc (right):

https://codereview.chromium.org/1254113004/diff/60001/chromecast/crash/linux/...
chromecast/crash/linux/dump_info_unittest.cc:196: }  // chromecast
nit: // namespace chromecast

[bcf_google, 2015-07-29 00:51:29]

https://codereview.chromium.org/1254113004/diff/60001/chromecast/crash/linux/...
File chromecast/crash/linux/dump_info_unittest.cc (right):

https://codereview.chromium.org/1254113004/diff/60001/chromecast/crash/linux/...
chromecast/crash/linux/dump_info_unittest.cc:196: }  // chromecast
On 2015/07/29 00:46:12, slan wrote:
> nit: // namespace chromecast

Done.

[bcf_google, 2015-07-29 00:52:04]

The CQ bit was checked by bcf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 00:53:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254113004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254113004/80001

[commit-bot: I haz the power, 2015-07-29 01:45:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 01:45:35]

Dry run: This issue passed the CQ dry run.

[bcf_google, 2015-07-29 18:17:15]

The CQ bit was checked by bcf@google.com

[bcf_google, 2015-07-29 18:17:16]

The patchset sent to the CQ was uploaded after l-g-t-m from gunsch@chromium.org,
slan@chromium.org
Link to the patchset: https://codereview.chromium.org/1254113004/#ps80001
(title: "Fixed namespace footer comment")

[commit-bot: I haz the power, 2015-07-29 18:18:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1254113004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1254113004/80001

[commit-bot: I haz the power, 2015-07-29 18:24:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-29 18:24:31]

Patchset 5 (id:??) landed as
https://crrev.com/62f6287af58fa80a2b830e436ea4f8dd20b8e1d5
Cr-Commit-Position: refs/heads/master@{#340924}