Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chromecast/crash/linux/dump_info_unittest.cc

Issue 1254113004: [Chromecast] Consolidate duplicated crash test functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fixed namespace footer comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromecast/crash/linux/minidump_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/dump_info_unittest.cc
diff --git a/chromecast/crash/linux/dump_info_unittest.cc b/chromecast/crash/linux/dump_info_unittest.cc
index fcbd646b2a42043986456307e074c4c0daa67f2d..c567e8e146d94f22350846382487f213816dc62c 100644
--- a/chromecast/crash/linux/dump_info_unittest.cc
+++ b/chromecast/crash/linux/dump_info_unittest.cc
@@ -5,21 +5,12 @@
#include <time.h>
#include "base/values.h"
-#include "chromecast/base/serializers.h"
+#include "chromecast/crash/linux/crash_testing_utils.h"
#include "chromecast/crash/linux/dump_info.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromecast {
-namespace {
-
-scoped_ptr<DumpInfo> CreateDumpInfo(const std::string& json_string) {
- scoped_ptr<base::Value> value(DeserializeFromJson(json_string));
- return make_scoped_ptr(new DumpInfo(value.get()));
-}
-
-} // namespace
-
TEST(DumpInfoTest, EmptyStringIsNotValid) {
scoped_ptr<DumpInfo> dump_info(CreateDumpInfo(""));
ASSERT_FALSE(dump_info->valid());
@@ -202,4 +193,4 @@ TEST(DumpInfoTest, TooManyFieldsIsNotValid) {
ASSERT_FALSE(info->valid());
}
-} // chromecast
+} // namespace chromecast
« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromecast/crash/linux/minidump_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698