Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253543003: Cleanup LayoutTextControl and its subclasses. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup LayoutTextControl and its subclasses. - Passes font family name via |const AtomicString&| instead of |AtomicString|. - Constify getAvgCharWidth(). This CL doesn't change any behaviors. BUG= Committed: https://crrev.com/24e0391654b1f9344b4c6fa357326728e012f533 git-svn-id: svn://svn.chromium.org/blink/trunk@199420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/layout/LayoutTextControl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTextControl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTextControlMultiLine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlMultiLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Keishi, please review this trivial patch.
5 years, 5 months ago (2015-07-24 02:08:27 UTC) #2
keishi
lgtm
5 years, 5 months ago (2015-07-24 02:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253543003/1
5 years, 5 months ago (2015-07-24 03:55:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199420
5 years, 5 months ago (2015-07-24 07:31:27 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:45:41 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24e0391654b1f9344b4c6fa357326728e012f533

Powered by Google App Engine
This is Rietveld 408576698