Source/core/layout/LayoutTextControlMultiLine.h - Issue 1253543003: Cleanup LayoutTextControl and its subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTextControlMultiLine.h

Issue 1253543003: Cleanup LayoutTextControl and its subclasses. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutTextControlMultiLine.h

diff --git a/Source/core/layout/LayoutTextControlMultiLine.h b/Source/core/layout/LayoutTextControlMultiLine.h

index b7f15b0f2ad05376781c42cbdb1b6f440446cdce..faf639d925d40a48e4687248793d4c0b46481157 100644

--- a/Source/core/layout/LayoutTextControlMultiLine.h

+++ b/Source/core/layout/LayoutTextControlMultiLine.h

@@ -38,7 +38,7 @@ private:

bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;

- float getAvgCharWidth(AtomicString family) override;

+ float getAvgCharWidth(const AtomicString& family) const override;

LayoutUnit preferredContentLogicalWidth(float charWidth) const override;

LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const override;

// We override the two baseline functions because we want our baseline to be the bottom of our margin box.