Source/core/layout/LayoutTextControl.h - Issue 1253543003: Cleanup LayoutTextControl and its subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTextControl.h

Issue 1253543003: Cleanup LayoutTextControl and its subclasses. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutTextControl.h

diff --git a/Source/core/layout/LayoutTextControl.h b/Source/core/layout/LayoutTextControl.h

index 2efb3c79a24241f61509727def734a5e6a9679b4..cea44b2196b4d90330a4a370e8b37e5c0fc894b9 100644

--- a/Source/core/layout/LayoutTextControl.h

+++ b/Source/core/layout/LayoutTextControl.h

@@ -58,8 +58,8 @@ protected:

float scaleEmToUnits(int x) const;

- static bool hasValidAvgCharWidth(AtomicString family);

- virtual float getAvgCharWidth(AtomicString family);

+ static bool hasValidAvgCharWidth(const AtomicString& family);

+ virtual float getAvgCharWidth(const AtomicString& family) const;

virtual LayoutUnit preferredContentLogicalWidth(float charWidth) const = 0;

virtual LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const = 0;

« no previous file with comments | « no previous file | Source/core/layout/LayoutTextControl.cpp » ('j') | no next file with comments »