Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 1253143002: Static semantics v0.1 (Closed)

Created:
5 years, 5 months ago by Leaf
Modified:
5 years, 4 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Static semantics v0.1. This now contains a fairly complete version of the static semantics for a core language, along with a translation into the same core language extended with a few small primitives. The insertion of covariance type checks is handled. Per Siggi's suggestion, I've moved the extended core language primitives into the elaboration section. The main changes from the last checkin are the treatment of classes, class hierarchies, override checking, etc. I've added some text to explain the general idea of what's going on. I've gone ahead an uploaded a pdf version to the site.dev_compiler repository that matches the version in this CL. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0727ecf1577da0da56ef9bd07f98db82636d046e

Patch Set 1 #

Total comments: 14

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -66 lines) Patch
M doc/definition/macros.tex View 1 1 chunk +3 lines, -0 lines 0 comments Download
M doc/definition/static-semantics.tex View 1 15 chunks +520 lines, -14 lines 0 comments Download
M doc/definition/strong-dart.pdf View 1 Binary file 0 comments Download
M doc/definition/strong-dart.tex View 1 9 chunks +80 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Leaf
5 years, 5 months ago (2015-07-24 21:55:12 UTC) #2
vsm
lgtm General question.... We currently allow this: class Foo { dynamic baz(dynamic x) => ...; ...
5 years, 4 months ago (2015-07-28 15:44:32 UTC) #3
Leaf
On 2015/07/28 15:44:32, vsm wrote: > lgtm > > General question.... > > We currently ...
5 years, 4 months ago (2015-07-28 20:34:22 UTC) #4
Leaf
https://codereview.chromium.org/1253143002/diff/1/doc/definition/static-semantics.tex File doc/definition/static-semantics.tex (left): https://codereview.chromium.org/1253143002/diff/1/doc/definition/static-semantics.tex#oldcode399 doc/definition/static-semantics.tex:399: \comment{TODO(leafp): specify ground types} On 2015/07/28 15:44:32, vsm wrote: ...
5 years, 4 months ago (2015-07-28 20:34:29 UTC) #5
vsm
lgtm
5 years, 4 months ago (2015-07-28 21:02:24 UTC) #6
Leaf
5 years, 4 months ago (2015-07-28 22:29:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0727ecf1577da0da56ef9bd07f98db82636d046e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698