Issue 1265903002: CSSValue Immediates: Remove redundant isTaggedPtr() checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265903002: CSSValue Immediates: Remove redundant isTaggedPtr() checks (Closed)

Created:
5 years, 4 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@tagged_ptrs_base

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Remove redundant isTaggedPtr() checks Refactored some CSSPrimitiveValue functions to only check if an object is a tagged pointer once. Also took advantage of context-specific knowledge about the object to prevent further checks of the pointer type. Depends on crrev.com/1252683002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -225 lines)			Patch
M	Source/core/css/CSSPrimitiveValue.h	View	5 chunks	+105 lines, -48 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View	13 chunks	+77 lines, -64 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View	100 chunks	+115 lines, -113 lines	0 comments	Download

Depends on Patchset:

Issue 1252683002 Patch 80008