Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1251843002: Using WireMessage instead of FakeWireMessage. (Closed)

Created:
5 years, 5 months ago by sacomoto
Modified:
5 years, 4 months ago
Reviewers:
Tim Song, msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using WireMessage instead of FakeWireMessage. This CL breaks the compatibility with BLE devices expecting FakeWireMessages. This CL also fixes a bug when reconnecting to a given device. It no longer removes the |adapter_| after the right device is found. BUG=513675 Committed: https://crrev.com/7ae8d9c314c283e9d2d8b72e106d6625a009e7bc Cr-Commit-Position: refs/heads/master@{#341872}

Patch Set 1 #

Patch Set 2 : Cleaning up. #

Patch Set 3 : Rebasing #

Patch Set 4 : Fix #

Patch Set 5 : Fixing notification issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M components/proximity_auth/ble/bluetooth_low_energy_connection.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/ble/proximity_auth_ble_system.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/connection.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sacomoto
PTAL.
5 years, 5 months ago (2015-07-22 11:33:39 UTC) #2
msarda
Please add a bug for this change as it breaks the protocol between Chrome and ...
5 years, 5 months ago (2015-07-22 12:38:45 UTC) #3
Tim Song
lgtm
5 years, 5 months ago (2015-07-23 21:23:10 UTC) #4
sacomoto
I filled a bug associated to this CL. I'm holding this CL until we are ...
5 years, 5 months ago (2015-07-24 13:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251843002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251843002/80001
5 years, 4 months ago (2015-08-05 08:13:42 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-05 09:05:18 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 09:07:12 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7ae8d9c314c283e9d2d8b72e106d6625a009e7bc
Cr-Commit-Position: refs/heads/master@{#341872}

Powered by Google App Engine
This is Rietveld 408576698