Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_connection.cc

Issue 1251843002: Using WireMessage instead of FakeWireMessage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing notification issue Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/ble/bluetooth_low_energy_connection.cc
diff --git a/components/proximity_auth/ble/bluetooth_low_energy_connection.cc b/components/proximity_auth/ble/bluetooth_low_energy_connection.cc
index 3d7586e883f9b4a4c7d471d15e24bcb9eec5b0c5..e2c1153aa1df12067848eb607a0c119bcc3fdd5b 100644
--- a/components/proximity_auth/ble/bluetooth_low_energy_connection.cc
+++ b/components/proximity_auth/ble/bluetooth_low_energy_connection.cc
@@ -299,11 +299,6 @@ BluetoothLowEnergyConnection::WriteRequest::WriteRequest(
BluetoothLowEnergyConnection::WriteRequest::~WriteRequest() {
}
-scoped_ptr<WireMessage> BluetoothLowEnergyConnection::DeserializeWireMessage(
- bool* is_incomplete_message) {
- return FakeWireMessage::Deserialize(received_bytes(), is_incomplete_message);
-}
-
void BluetoothLowEnergyConnection::CompleteConnection() {
PA_LOG(INFO) << "Connection completed. Time elapsed: "
<< base::TimeTicks::Now() - start_time_;
@@ -480,7 +475,7 @@ void BluetoothLowEnergyConnection::OnRemoteCharacteristicWritten(
write_remote_characteristic_pending_ = false;
// TODO(sacomoto): Actually pass the current message to the observer.
if (run_did_send_message_callback)
- OnDidSendMessage(FakeWireMessage(""), true);
+ OnDidSendMessage(WireMessage(std::string(), std::string()), true);
// Removes the top of queue (already processed) and process the next request.
DCHECK(!write_requests_queue_.empty());
@@ -496,7 +491,7 @@ void BluetoothLowEnergyConnection::OnWriteRemoteCharacteristicError(
write_remote_characteristic_pending_ = false;
// TODO(sacomoto): Actually pass the current message to the observer.
if (run_did_send_message_callback)
- OnDidSendMessage(FakeWireMessage(""), false);
+ OnDidSendMessage(WireMessage(std::string(), std::string()), false);
// Increases the number of failed attempts and retry.
DCHECK(!write_requests_queue_.empty());

Powered by Google App Engine
This is Rietveld 408576698