DescriptionFix BufferedSocketWriter not to return any results from Write().
Previously BufferedSocketWriter was returning false from Write() if
the write fails synchronously. That's redundant because
BufferedSocketWriter also calls a callback after the failed write.
This also fixes a bug in Write() - it was using is_closed() method after
calling the callback, which is not allowed because the object may be
deleted by the callback. That problem was found by tests added in
https://codereview.chromium.org/1258323003 . The bug was introduced
recently in https://codereview.chromium.org/1197853003 .
Committed: https://crrev.com/7e2c7b2f3fc93e1acd950e6dad14cf9f6919984f
Cr-Commit-Position: refs/heads/master@{#341229}
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
|