Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: remoting/protocol/channel_multiplexer_unittest.cc

Issue 1250403003: Fix BufferedSocketWriter not to return any results from Write(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/channel_multiplexer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/channel_multiplexer_unittest.cc
diff --git a/remoting/protocol/channel_multiplexer_unittest.cc b/remoting/protocol/channel_multiplexer_unittest.cc
index 94ee44e12251cfe39ccf1f63ef6025ec00efd303..72448e2e4ebdf9724dcb9ed75cc278e4ba1a1f69 100644
--- a/remoting/protocol/channel_multiplexer_unittest.cc
+++ b/remoting/protocol/channel_multiplexer_unittest.cc
@@ -254,18 +254,15 @@ TEST_F(ChannelMultiplexerTest, WriteFailSync) {
MockSocketCallback cb1;
MockSocketCallback cb2;
+ EXPECT_CALL(cb1, OnDone(net::ERR_FAILED));
+ EXPECT_CALL(cb2, OnDone(net::ERR_FAILED));
- EXPECT_CALL(cb1, OnDone(_))
- .Times(0);
- EXPECT_CALL(cb2, OnDone(_))
- .Times(0);
-
- EXPECT_EQ(net::ERR_FAILED,
+ EXPECT_EQ(net::ERR_IO_PENDING,
host_socket1_->Write(buf.get(),
buf->size(),
base::Bind(&MockSocketCallback::OnDone,
base::Unretained(&cb1))));
- EXPECT_EQ(net::ERR_FAILED,
+ EXPECT_EQ(net::ERR_IO_PENDING,
host_socket2_->Write(buf.get(),
buf->size(),
base::Bind(&MockSocketCallback::OnDone,
« no previous file with comments | « remoting/protocol/channel_multiplexer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698