Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(88)

Issue 1250403003: Fix BufferedSocketWriter not to return any results from Write(). (Closed)

Created:
5 years, 2 months ago by Sergey Ulanov
Modified:
5 years, 2 months ago
Reviewers:
Wez, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BufferedSocketWriter not to return any results from Write(). Previously BufferedSocketWriter was returning false from Write() if the write fails synchronously. That's redundant because BufferedSocketWriter also calls a callback after the failed write. This also fixes a bug in Write() - it was using is_closed() method after calling the callback, which is not allowed because the object may be deleted by the callback. That problem was found by tests added in https://codereview.chromium.org/1258323003 . The bug was introduced recently in https://codereview.chromium.org/1197853003 . Committed: https://crrev.com/7e2c7b2f3fc93e1acd950e6dad14cf9f6919984f Cr-Commit-Position: refs/heads/master@{#341229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M remoting/base/buffered_socket_writer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/base/buffered_socket_writer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/protocol/channel_multiplexer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M remoting/protocol/channel_multiplexer_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
5 years, 2 months ago (2015-07-30 16:41:42 UTC) #2
Sergey Ulanov
-wez, +dcaiafa. Dan, can you please take a look?
5 years, 2 months ago (2015-07-30 23:01:46 UTC) #4
Wez
lgtm
5 years, 2 months ago (2015-07-30 23:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250403003/1
5 years, 2 months ago (2015-07-30 23:13:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-07-30 23:58:40 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-07-30 23:59:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e2c7b2f3fc93e1acd950e6dad14cf9f6919984f
Cr-Commit-Position: refs/heads/master@{#341229}

Powered by Google App Engine
This is Rietveld 408576698