Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/40001
5 years, 5 months ago
(2015-08-25 06:02:36 UTC)
#4
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/89470)
5 years, 5 months ago
(2015-08-25 06:16:00 UTC)
#6
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/60001
5 years, 5 months ago
(2015-08-25 13:12:42 UTC)
#8
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103843)
5 years, 5 months ago
(2015-08-25 14:06:26 UTC)
#10
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/60001
5 years, 5 months ago
(2015-08-26 07:37:33 UTC)
#12
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/98612)
5 years, 5 months ago
(2015-08-26 08:47:43 UTC)
#14
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/80001
5 years, 5 months ago
(2015-08-27 06:45:57 UTC)
#16
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99330)
5 years, 5 months ago
(2015-08-27 08:24:07 UTC)
#18
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/100001
5 years, 5 months ago
(2015-08-28 00:47:48 UTC)
#20
5 years, 5 months ago
(2015-08-28 03:08:35 UTC)
#22
Dry run: This issue passed the CQ dry run.
acterhd
On 2015/08/28 03:08:35, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 5 months ago
(2015-08-28 11:40:24 UTC)
#23
On 2015/08/28 03:08:35, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.
lgtm
Noel Gordon
@acterhd you are not a chromium committer, nor do you possess the right to approve ...
5 years, 5 months ago
(2015-08-28 12:19:12 UTC)
#24
@acterhd you are not a chromium committer, nor do you possess the right to
approve patches.
@max due to ^^^, please close this issue an re-open it in a new issue.
Noel Gordon
.. ahem, and reopen it in a new issue, also while we are here ...
5 years, 5 months ago
(2015-08-28 12:21:04 UTC)
#25
.. ahem, and reopen it in a new issue, also while we are here ...
On 2015/08/28 12:23:15, noel gordon wrote: > https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt > File LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt > (right): > > ...
5 years, 5 months ago
(2015-08-28 14:53:16 UTC)
#28
On 2015/08/28 12:23:15, noel gordon wrote:
>
https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/phi...
> File LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt
> (right):
>
>
https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/phi...
> LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt:1:
> Failed assertion: got pixel [255,0,0,255] at (50,25), expected [0,255,0,255]
+/-
> 2
> Better to find out why the test change behavior, rather than mark it failed.
OK, I will open the new issue.
The test behavior change was expected.
Firefox gives the same result (since it supports APNG), as you can see here:
http://www.w3c-test.org/2dcontext/drawing-images-to-the-canvas/2d.drawImage.a...
There are two APNG files and one AGIF in LayoutTests/canvas/philip/images/
The tests make sure that canvas drawImage() will always render the first
(poster) frame.
But for APNG, the poster frame could be marked hidden, and not be part of the
animation.
In this case, PNG decoder will ignore it. To save memory and decoding time, it
will
never decode it. So when canvas drawImage() will request the first/poster image,
the decoder will always return the first *visible* frame, aka
m_frameBufferCache[0]
This test expects that hidden poster frame of APNG.
But from practical point of view, serving the first visible frame is much
easier.
MaxStepin
Moved here: https://codereview.chromium.org/1312843006/
5 years, 5 months ago
(2015-08-28 15:32:37 UTC)
#29
Issue 1250373006: Animated PNG implementation
(Closed)
Created 5 years, 5 months ago by MaxStepin
Modified 5 years, 5 months ago
Reviewers:
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 1