Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1250373006: Animated PNG implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by MaxStepin
Modified:
2 years, 1 month ago
Reviewers:
acterhd
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Animated PNG implementation BUG=1171 BUG=437662

Patch Set 1 #

Patch Set 2 : Perfomance tweaks, code cleanup. #

Patch Set 3 : Another performance tweak. #

Patch Set 4 : compilation fix #

Patch Set 5 : Fixing tests. #

Patch Set 6 : Another LayoutTests fix. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -67 lines) Patch
M LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 1 comment Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/image-decoders/ImageFrame.h View 1 chunk +39 lines, -0 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.h View 2 chunks +11 lines, -6 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 2 3 4 5 16 chunks +413 lines, -60 lines 0 comments Download
A Source/platform/image-decoders/png/PNGImageDecoderTest.cpp View 1 1 chunk +121 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 29 (12 generated)
acterhd
On 2015/08/03 10:24:56, MaxStepin wrote: > mailto:maxstepin@gmail.com changed reviewers: > + mailto:noel@chromium.org Sad no subscribers. ...
2 years, 2 months ago (2015-08-21 18:54:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/40001
2 years, 2 months ago (2015-08-25 06:02:36 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/89470)
2 years, 2 months ago (2015-08-25 06:16:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/60001
2 years, 1 month ago (2015-08-25 13:12:42 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103843)
2 years, 1 month ago (2015-08-25 14:06:26 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/60001
2 years, 1 month ago (2015-08-26 07:37:33 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/98612)
2 years, 1 month ago (2015-08-26 08:47:43 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/80001
2 years, 1 month ago (2015-08-27 06:45:57 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99330)
2 years, 1 month ago (2015-08-27 08:24:07 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250373006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250373006/100001
2 years, 1 month ago (2015-08-28 00:47:48 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
2 years, 1 month ago (2015-08-28 03:08:35 UTC) #22
acterhd
On 2015/08/28 03:08:35, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
2 years, 1 month ago (2015-08-28 11:40:24 UTC) #23
Noel Gordon
@acterhd you are not a chromium committer, nor do you possess the right to approve ...
2 years, 1 month ago (2015-08-28 12:19:12 UTC) #24
Noel Gordon
.. ahem, and reopen it in a new issue, also while we are here ...
2 years, 1 month ago (2015-08-28 12:21:04 UTC) #25
Noel Gordon
https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt File LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt (right): https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt#newcode1 LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt:1: Failed assertion: got pixel [255,0,0,255] at (50,25), expected [0,255,0,255] ...
2 years, 1 month ago (2015-08-28 12:23:15 UTC) #26
MaxStepin
On 2015/08/28 12:23:15, noel gordon wrote: > https://codereview.chromium.org/1250373006/diff/100001/LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt > File LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt > (right): > > ...
2 years, 1 month ago (2015-08-28 14:53:16 UTC) #28
MaxStepin
2 years, 1 month ago (2015-08-28 15:32:37 UTC) #29
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa