Issue 1312843006: Animated PNG implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1312843006: Animated PNG implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 years ago by MaxStepin

Modified:
1 year, 8 months ago

Reviewers:
Noel Gordon

CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Animated PNG implementation BUG=1171 BUG=437662

Patch Set 1 #

Created: 2 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+587 lines, -67 lines)			Patch
M	LayoutTests/canvas/philip/tests/2d.drawImage.animated.poster-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/image-decoders/ImageFrame.h	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	Source/platform/image-decoders/png/PNGImageDecoder.h	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	Source/platform/image-decoders/png/PNGImageDecoder.cpp	View	16 chunks	+413 lines, -60 lines	0 comments	Download
A	Source/platform/image-decoders/png/PNGImageDecoderTest.cpp	View	1 chunk	+121 lines, -0 lines	0 comments	Download

Trybot results: win8_chromium_ng win_chromium_compile_dbg_ng win_chromium_x64_rel_ng win_chromium_rel_ng ios_rel_device_ninja ios_dbg_simulator_ninja mac_chromium_compile_dbg_ng linux_chromium_clobber_rel_ng mac_chromium_rel_ng linux_chromium_chromeos_compile_dbg_ng android_clang_dbg_recipe chromeos_x86-generic_chromium_compile_only_ng chromeos_daisy_chromium_compile_only_ng linux_chromium_gn_chromeos_rel cast_shell_android chromium_presubmit linux_chromium_asan_rel_ng chromeos_amd64-generic_chromium_compile_only_ng linux_chromium_rel_ng cast_shell_linux linux_chromium_gn_rel android_compile_dbg android_chromium_gn_compile_rel linux_chromium_gn_dbg linux_android_rel_ng android_arm64_dbg_recipe android_chromium_gn_compile_dbg linux_chromium_chromeos_ozone_rel_ng linux_chromium_compile_dbg_32_ng linux_chromium_chromeos_rel_ng

Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312843006/1

2 years ago (2015-08-29 08:46:52 UTC) #3

Dry run: This issue passed the CQ dry run.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages