Issue 1250163002: Fix cross-process location.replace for main frames and subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1250163002: Fix cross-process location.replace for main frames and subframes. (Closed)

Created:
5 years, 5 months ago by Charlie Reis

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix cross-process location.replace for main frames and subframes. BUG=317872 TEST=Forward history not cleared on OOPIF location.replace.

Patch Set 1 #

Patch Set 2 : More adjustments. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase for initial blank FNEs #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Fix more tests #

Patch Set 8 : Rebase and remove some code #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -86 lines)			Patch
M	content/browser/frame_host/navigation_controller_impl.h	View	1 2 3 4 5	2 chunks	+6 lines, -4 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View	1 2 3 4 5 6 7	4 chunks	+13 lines, -5 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_browsertest.cc	View	1 2 3 4 5 6 7	21 chunks	+152 lines, -59 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/frame_messages.h	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2 3 4 5 6 7	5 chunks	+32 lines, -8 lines	0 comments	Download
M	content/test/test_render_frame_host.h	View	1 2 3 4 5 6	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/test/test_render_frame_host.cc	View	1 2 3 4 5 6 7	5 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Reis

3 years, 5 months ago (2017-07-11 22:45:01 UTC) #2

Description was changed from

==========
Fix cross-process location.replace for main frames and subframes.

BUG=317872
TEST=Forward history not cleared on OOPIF location.replace.
==========

to

==========
Fix cross-process location.replace for main frames and subframes.

BUG=317872
TEST=Forward history not cleared on OOPIF location.replace.
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages