Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1250163002: Fix cross-process location.replace for main frames and subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and remove some code Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 265
266 // Handlers for the different types of navigation types. They will actually 266 // Handlers for the different types of navigation types. They will actually
267 // handle the navigations corresponding to the different NavClasses above. 267 // handle the navigations corresponding to the different NavClasses above.
268 // They will NOT broadcast the commit notification, that should be handled by 268 // They will NOT broadcast the commit notification, that should be handled by
269 // the caller. 269 // the caller.
270 // 270 //
271 // RendererDidNavigateAutoSubframe is special, it may not actually change 271 // RendererDidNavigateAutoSubframe is special, it may not actually change
272 // anything if some random subframe is loaded. It will return true if anything 272 // anything if some random subframe is loaded. It will return true if anything
273 // changed, or false if not. 273 // changed, or false if not.
274 // 274 //
275 // The functions taking |did_replace_entry| will fill into the given variable 275 // The NewPage and NewSubframe functions take in |replace_entry| to pass to
276 // whether the last entry has been replaced or not. 276 // InsertOrReplaceEntry, in case the newly created NavigationEntry is meant to
277 // See LoadCommittedDetails.did_replace_entry. 277 // replace the current one (e.g., for location.replace), in contrast to
278 // updating a NavigationEntry in place (e.g., for history.replaceState).
278 void RendererDidNavigateToNewPage( 279 void RendererDidNavigateToNewPage(
279 RenderFrameHostImpl* rfh, 280 RenderFrameHostImpl* rfh,
280 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 281 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
281 bool replace_entry); 282 bool replace_entry);
282 void RendererDidNavigateToExistingPage( 283 void RendererDidNavigateToExistingPage(
283 RenderFrameHostImpl* rfh, 284 RenderFrameHostImpl* rfh,
284 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 285 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
285 void RendererDidNavigateToSamePage( 286 void RendererDidNavigateToSamePage(
286 RenderFrameHostImpl* rfh, 287 RenderFrameHostImpl* rfh,
287 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 288 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
288 void RendererDidNavigateNewSubframe( 289 void RendererDidNavigateNewSubframe(
289 RenderFrameHostImpl* rfh, 290 RenderFrameHostImpl* rfh,
290 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 291 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
292 bool replace_entry);
291 bool RendererDidNavigateAutoSubframe( 293 bool RendererDidNavigateAutoSubframe(
292 RenderFrameHostImpl* rfh, 294 RenderFrameHostImpl* rfh,
293 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 295 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
294 296
295 // Helper function for code shared between Reload() and ReloadIgnoringCache(). 297 // Helper function for code shared between Reload() and ReloadIgnoringCache().
296 void ReloadInternal(bool check_for_repost, ReloadType reload_type); 298 void ReloadInternal(bool check_for_repost, ReloadType reload_type);
297 299
298 // Actually issues the navigation held in pending_entry. 300 // Actually issues the navigation held in pending_entry.
299 void NavigateToPendingEntry(ReloadType reload_type); 301 void NavigateToPendingEntry(ReloadType reload_type);
300 302
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 TimeSmoother time_smoother_; 445 TimeSmoother time_smoother_;
444 446
445 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_; 447 scoped_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
446 448
447 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 449 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
448 }; 450 };
449 451
450 } // namespace content 452 } // namespace content
451 453
452 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 454 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698