Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 1249053002: Fix build/secondary/third_party/nss/BUILD.gn on iOS. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-gen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build/secondary/third_party/nss/BUILD.gn on iOS. Compilers configuration have been moved from //build/compiler to //build/config/compiler, update //third_party/nss when targetting iOS. BUG=459705 Committed: https://crrev.com/768d90d3853fa121580923b0944998354c592a01 Cr-Commit-Position: refs/heads/master@{#340057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/secondary/third_party/nss/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 5 months ago (2015-07-22 16:45:07 UTC) #2
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-22 16:45:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1249053002/1
5 years, 5 months ago (2015-07-23 07:50:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 08:29:20 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 08:29:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/768d90d3853fa121580923b0944998354c592a01
Cr-Commit-Position: refs/heads/master@{#340057}

Powered by Google App Engine
This is Rietveld 408576698