Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1253463002: Fix components/rlz/BUILD.gn on iOS. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@nss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix components/rlz/BUILD.gn on iOS. The intention of the code was to add //ui/base to the list of deps when building for iOS, not to replace the list, so use the correct operator. BUG=459705 Committed: https://crrev.com/d336c9f3c43921fda32cddeeb42ed116fd9f5d55 Cr-Commit-Position: refs/heads/master@{#340062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/rlz/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 5 months ago (2015-07-22 16:49:21 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 5 months ago (2015-07-22 18:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253463002/1
5 years, 5 months ago (2015-07-23 09:11:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 09:45:31 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 09:46:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d336c9f3c43921fda32cddeeb42ed116fd9f5d55
Cr-Commit-Position: refs/heads/master@{#340062}

Powered by Google App Engine
This is Rietveld 408576698