Issue 1249043002: v8_use_external_startup_data should be false on iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1249043002: v8_use_external_startup_data should be false on iOS (Closed)

Created:
5 years, 5 months ago by sdefresne

Modified:
5 years, 5 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

v8_use_external_startup_data should be false on iOS iOS does not build V8, so v8_use_external_startup_data should be false when target_os is "ios". BUG=459705 Committed: https://crrev.com/9ca6cf93217b02c8a8ae5b183e9f0dc4adeba58b Cr-Commit-Position: refs/heads/master@{#339915}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/module_args/v8.gni	View		1 chunk	+1 line, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1249053002 Patch 1

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249043002/1

5 years, 5 months ago (2015-07-22 17:45:41 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 18:16:44 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9ca6cf93217b02c8a8ae5b183e9f0dc4adeba58b
Cr-Commit-Position: refs/heads/master@{#339915}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages