content/browser/renderer_host/render_widget_host_view_base.h - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 21266f153ba40ebe6d53449e7581ea8fb95e3b26..75baf81a43417a9ce616a9bee71b1cdc7b39b9a8 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -34,6 +34,7 @@ class SkBitmap;

struct AccessibilityHostMsg_EventParams;

struct ViewHostMsg_SelectionBounds_Params;

+struct ViewHostMsg_TextInputState_Params;

namespace media {

class VideoFrame;

@@ -207,11 +208,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

// Indicates whether the page has finished loading.

virtual void SetIsLoading(bool is_loading) = 0;

- // Updates the type of the input method attached to the view.

- virtual void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode mode,

- bool can_compose_inline,

- int flags) = 0;

+ // Updates the state of the input method attached to the view.

+ virtual void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) = 0;

// Cancel the ongoing composition of the input method attached to the view.

virtual void ImeCancelComposition() = 0;