content/browser/renderer_host/render_widget_host_view_mac.h - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.h

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h

index 057b8b90b7b71bbee0894c72880ff8ac41746465..0f6a82678cf7d08d97718dfb1a0c95b8dc210783 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.h

+++ b/content/browser/renderer_host/render_widget_host_view_mac.h

@@ -35,6 +35,8 @@

#import "ui/base/cocoa/tool_tip_base_view.h"

#include "ui/gfx/display_observer.h"

+struct ViewHostMsg_TextInputState_Params;

namespace content {

class RenderWidgetHostImpl;

class RenderWidgetHostViewMac;

@@ -290,10 +292,8 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

void Focus() override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode input_mode,

- bool can_compose_inline,

- int flags) override;

+ void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) override;

void ImeCancelComposition() override;

void ImeCompositionRangeChanged(

const gfx::Range& range,