Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 39478215fd4bcb637429184c6f5f798dbe9f05fc..5933633e041c26f472aa1913ea90f27372c66fc1 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -489,11 +489,6 @@ bool RenderWidgetHostViewAura::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewAura, message)
- // TODO(kevers): Move to RenderWidgetHostViewImpl and consolidate IPC
- // messages for TextInput<State|Type>Changed. Corresponding code in
- // RenderWidgetHostViewAndroid should also be moved at the same time.
- IPC_MESSAGE_HANDLER(ViewHostMsg_TextInputStateChanged,
- OnTextInputStateChanged)
IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,
OnSetNeedsBeginFrames)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -950,29 +945,21 @@ void RenderWidgetHostViewAura::SetIsLoading(bool is_loading) {
UpdateCursorIfOverSelf();
}
-void RenderWidgetHostViewAura::TextInputTypeChanged(
- ui::TextInputType type,
- ui::TextInputMode input_mode,
- bool can_compose_inline,
- int flags) {
- if (text_input_type_ != type ||
- text_input_mode_ != input_mode ||
- can_compose_inline_ != can_compose_inline ||
- text_input_flags_ != flags) {
- text_input_type_ = type;
- text_input_mode_ = input_mode;
- can_compose_inline_ = can_compose_inline;
- text_input_flags_ = flags;
+void RenderWidgetHostViewAura::TextInputStateChanged(
+ const ViewHostMsg_TextInputState_Params& params) {
+ if (text_input_type_ != params.type ||
+ text_input_mode_ != params.mode ||
+ can_compose_inline_ != params.can_compose_inline ||
+ text_input_flags_ != params.flags) {
+ text_input_type_ = params.type;
+ text_input_mode_ = params.mode;
+ can_compose_inline_ = params.can_compose_inline;
+ text_input_flags_ = params.flags;
if (GetInputMethod())
GetInputMethod()->OnTextInputTypeChanged(this);
if (touch_editing_client_)
touch_editing_client_->OnTextInputTypeChanged(text_input_type_);
}
-}
-
-void RenderWidgetHostViewAura::OnTextInputStateChanged(
- const ViewHostMsg_TextInputState_Params& params) {
- text_input_flags_ = params.flags;
if (params.show_ime_if_needed && params.type != ui::TEXT_INPUT_TYPE_NONE) {
if (GetInputMethod())
GetInputMethod()->ShowImeIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698