Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index e0f76f1d4a5f7476a553a10b91f40861e6561ba4..56bb522e32a8b51fdff6beadbf2653a50310b4a1 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -38,6 +38,8 @@
#include "ui/gfx/geometry/rect.h"
#include "ui/wm/public/activation_delegate.h"
+struct ViewHostMsg_TextInputState_Params;
+
namespace aura {
class WindowTracker;
namespace client {
@@ -169,10 +171,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void Focus() override;
void UpdateCursor(const WebCursor& cursor) override;
void SetIsLoading(bool is_loading) override;
- void TextInputTypeChanged(ui::TextInputType type,
- ui::TextInputMode input_mode,
- bool can_compose_inline,
- int flags) override;
+ void TextInputStateChanged(
+ const ViewHostMsg_TextInputState_Params& params) override;
void ImeCancelComposition() override;
void ImeCompositionRangeChanged(
const gfx::Range& range,
@@ -310,8 +310,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void OnHostMoved(const aura::WindowTreeHost* host,
const gfx::Point& new_origin) override;
- void OnTextInputStateChanged(const ViewHostMsg_TextInputState_Params& params);
-
#if defined(OS_WIN)
// Sets the cutout rects from constrained windows. These are rectangles that
// windowed NPAPI plugins shouldn't paint in. Overwrites any previous cutout

Powered by Google App Engine
This is Rietveld 408576698