Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1248473002: password_manager bad_message.h: Use a sparse histogram. (Closed)

Created:
5 years, 5 months ago by ncarter (slow)
Modified:
5 years, 5 months ago
Reviewers:
vabr (Chromium), lfg
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

password_manager bad_message.h: Use a sparse histogram. [ This is the password_manager equivalent of https://crrev.com/d8ec87b3f93ecf173005fd6020e3f8d3774af128 ] BUG=None Committed: https://crrev.com/faee0518d307890065631e35502cfd09cf39e618 Cr-Commit-Position: refs/heads/master@{#339673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M components/password_manager/content/browser/bad_message.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/content/browser/bad_message.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ncarter (slow)
Hi Lucas, Please review!
5 years, 5 months ago (2015-07-20 21:22:36 UTC) #2
lfg
LGTM
5 years, 5 months ago (2015-07-20 21:33:22 UTC) #3
ncarter (slow)
+vabr: please approve
5 years, 5 months ago (2015-07-20 22:53:18 UTC) #5
vabr (Chromium)
lgtm
5 years, 5 months ago (2015-07-21 06:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248473002/1
5 years, 5 months ago (2015-07-21 16:15:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 17:15:25 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:16:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faee0518d307890065631e35502cfd09cf39e618
Cr-Commit-Position: refs/heads/master@{#339673}

Powered by Google App Engine
This is Rietveld 408576698