Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9213)

Unified Diff: components/password_manager/content/browser/bad_message.cc

Issue 1248473002: password_manager bad_message.h: Use a sparse histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/content/browser/bad_message.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/bad_message.cc
diff --git a/components/password_manager/content/browser/bad_message.cc b/components/password_manager/content/browser/bad_message.cc
index b1525566e072a24ef5a02df87dd2820c84d92a53..74c35273571a7693b000d21a53acbfecddb578dc 100644
--- a/components/password_manager/content/browser/bad_message.cc
+++ b/components/password_manager/content/browser/bad_message.cc
@@ -5,7 +5,7 @@
#include "components/password_manager/content/browser/bad_message.h"
#include "base/logging.h"
-#include "base/metrics/histogram_macros.h"
+#include "base/metrics/sparse_histogram.h"
#include "content/public/browser/render_process_host.h"
namespace password_manager {
@@ -16,10 +16,8 @@ void ReceivedBadMessage(content::RenderProcessHost* host,
LOG(ERROR)
<< "Terminating renderer for bad PasswordManager IPC message, reason "
<< static_cast<int>(reason);
- UMA_HISTOGRAM_ENUMERATION(
- "Stability.BadMessageTerminated.PasswordManager",
- static_cast<int>(reason),
- static_cast<int>(BadMessageReason::BAD_MESSAGE_MAX));
+ UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.PasswordManager",
+ static_cast<int>(reason));
host->ShutdownForBadMessage();
}
« no previous file with comments | « components/password_manager/content/browser/bad_message.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698