Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/password_manager/content/browser/bad_message.h

Issue 1248473002: password_manager bad_message.h: Use a sparse histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/bad_message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/bad_message.h
diff --git a/components/password_manager/content/browser/bad_message.h b/components/password_manager/content/browser/bad_message.h
index 641ca0ed43d3e04367187cf27c90faa6098fdbc8..37efbefd42c78a20e7ad7c1bdca8a0cb6a05777a 100644
--- a/components/password_manager/content/browser/bad_message.h
+++ b/components/password_manager/content/browser/bad_message.h
@@ -17,9 +17,7 @@ namespace password_manager {
//
// NOTE: Do not remove or reorder elements in this list. Add new entries at the
// end. Items may be renamed but do not change the values. We rely on the enum
-// values in histograms. Also update histograms.xml with any new values by
-// running:
-// python tools/metrics/histograms/update_bad_message_reasons.py
+// values in histograms.
enum class BadMessageReason {
CPMD_BAD_ORIGIN_FORMS_PARSED = 1,
CPMD_BAD_ORIGIN_FORMS_RENDERED = 2,
@@ -30,7 +28,9 @@ enum class BadMessageReason {
// Please add new elements here. The naming convention is abbreviated class
// name (e.g. ContentPasswordManagerDriver becomes CPMD) plus a unique
- // description of the reason.
+ // description of the reason. After making changes, you MUST update
+ // histograms.xml by running:
+ // "python tools/metrics/histograms/update_bad_message_reasons.py"
BAD_MESSAGE_MAX
};
« no previous file with comments | « no previous file | components/password_manager/content/browser/bad_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698