[Android] Fix a crash on restoring ProtectedContentResetCredentialConfirmDialogFragment.

[Android] Fix a crash on restoring ProtectedContentResetCredentialConfirmDialogFragment.

ProtectedContentResetCredentialConfirmDialogFragment doesn't support
restoring from being destroyed, which caused a crash.

Since this is not an important dialog to keep the context, simply
dismiss if it's being restored.

BUG=513238
Committed: https://crrev.com/81666e13c3da0290514d7656da86a28850928e05
Cr-Commit-Position: refs/heads/master@{#340207}

[Kibeom Kim (inactive), 2015-07-23 17:55:41]

kkimlabs@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-07-23 19:45:46]

Could you make this even simpler and just call

  DialogFragment.setRetainInstance(false)

?

[newt (away), 2015-07-23 19:45:47]

Could you make this even simpler and just call

  DialogFragment.setRetainInstance(false)

?

[Kibeom Kim (inactive), 2015-07-23 20:45:13]

On 2015/07/23 19:45:47, newt wrote:
> Could you make this even simpler and just call
> 
>   DialogFragment.setRetainInstance(false)
> 
> ?

Even if I set that to false, anyways it doesn't dismiss automatically, and if
it's not dismissed, |mListener| is null so will crash on clicking OK.

[newt (away), 2015-07-23 21:00:10]

lgtm

https://codereview.chromium.org/1248373003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
(right):

https://codereview.chromium.org/1248373003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java:37:
* @return Created {@link ProtectedContentResetCredentialConfirmDialogFragment}
instance.
I'd consider this line redundant. Feel free to remove it.

[Kibeom Kim (inactive), 2015-07-23 22:42:01]

The CQ bit was checked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2015-07-23 22:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1248373003/#ps20001
(title: "remove @return comment")

[Kibeom Kim (inactive), 2015-07-23 22:42:21]

https://codereview.chromium.org/1248373003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
(right):

https://codereview.chromium.org/1248373003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java:37:
* @return Created {@link ProtectedContentResetCredentialConfirmDialogFragment}
instance.
On 2015/07/23 21:00:10, newt wrote:
> I'd consider this line redundant. Feel free to remove it.

Done.

[commit-bot: I haz the power, 2015-07-23 22:42:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1248373003/20001

[commit-bot: I haz the power, 2015-07-23 23:21:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-23 23:22:12]

Patchset 2 (id:??) landed as
https://crrev.com/81666e13c3da0290514d7656da86a28850928e05
Cr-Commit-Position: refs/heads/master@{#340207}