chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java - Issue 1248373003: [Android] Fix a crash on restoring ProtectedContentResetCredentialConfirmDialogFragment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

Issue 1248373003: [Android] Fix a crash on restoring ProtectedContentResetCredentialConfirmDialogFragment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove @return comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

index aa9f0a4d5ab41353ba4ba61adf4192f166c9a9ec..1ba807d0a95a8087f1e6847fdca94b27d043bb11 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

@@ -332,8 +332,9 @@ public class SingleCategoryPreferences extends PreferenceFragment

resetMenu.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {

@Override

public boolean onMenuItemClick(MenuItem menuItem) {

- new ProtectedContentResetCredentialConfirmDialogFragment(

- SingleCategoryPreferences.this).show(getFragmentManager(), null);

+ ProtectedContentResetCredentialConfirmDialogFragment

+ .newInstance(SingleCategoryPreferences.this)

+ .show(getFragmentManager(), null);

return true;

}

});