Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java

Issue 1248373003: [Android] Fix a crash on restoring ProtectedContentResetCredentialConfirmDialogFragment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove @return comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
index e623a21437991046d81ddd5269897ccd4a11b00b..cc94ae0381b64da3c79f58acf9ac7c6feecf9370 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java
@@ -32,10 +32,15 @@ public class ProtectedContentResetCredentialConfirmDialogFragment extends Dialog
}
/**
+ * Creates a {@link ProtectedContentResetCredentialConfirmDialogFragment} instance.
* @param listener This is notified when user confirms to reset.
*/
- public ProtectedContentResetCredentialConfirmDialogFragment(Listener listener) {
- mListener = listener;
+ public static final ProtectedContentResetCredentialConfirmDialogFragment newInstance(
+ Listener listener) {
+ ProtectedContentResetCredentialConfirmDialogFragment fragment =
+ new ProtectedContentResetCredentialConfirmDialogFragment();
+ fragment.mListener = listener;
+ return fragment;
}
/**
@@ -44,6 +49,8 @@ public class ProtectedContentResetCredentialConfirmDialogFragment extends Dialog
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
super.onCreateDialog(savedInstanceState);
+ if (savedInstanceState != null) dismiss();
+
return new AlertDialog.Builder(getActivity(), R.style.AlertDialogTheme)
.setTitle(R.string.protected_content_reset_title)
.setMessage(R.string.protected_content_reset_message)
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698