Unify runtime-style IC functions with Runtime intrinsics

Unify "runtime-style" IC functions with Runtime intrinsics

Previous to this CL, ICs used a slightly different code idiom
to get to C++ code from generated code than runtime intrinsics,
using an IC_Utility class that in essence provided exactly
the same functionality as Runtime::FunctionForId, but in its
own quirky way.

This CL unifies the two mechanisms, folding IC_Utility
away by making all IC entry points in C++ code, e.g. IC
miss handlers, full-fledged runtime intrinsics. This makes
it possible to eliminate a bunch of ad-hoc declarations and
adapters that the IC system had to needlessly re-invent.

As a bonus and the original reason for this yak-shave:
IC-related C++ runtime functions are now callable from
TurboFan.

Committed: https://crrev.com/bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e
Cr-Commit-Position: refs/heads/master@{#29811}

[danno, 2015-07-23 11:18:58]

danno@chromium.org changed reviewers:
+ mstarzinger@chromium.org, yangguo@chromium.org

[danno, 2015-07-23 11:20:47]

PTAL

[Michael Starzinger, 2015-07-23 11:36:15]

LGTM, just nits. I like it!

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-deb...
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-deb...
src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTION(Runtime_DebugBreak) {
nit: Can we add the following boilerplate to the top of the function?

   SealHandleScope shs(isolate);
   DCHECK(args.length() == 0);

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h#n...
src/runtime/runtime.h:729: #define FOR_EACH_INTRINSIC_IC(F)             \
nit: Can we add a short one-line comment saying that those runtime function are
actually implemented in "ic.cc" file outside of the "runtime" directory?

[danno, 2015-07-23 11:50:22]

Feedback addressed. Landing.

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-deb...
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-deb...
src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTION(Runtime_DebugBreak) {
On 2015/07/23 at 11:36:15, Michael Starzinger wrote:
> nit: Can we add the following boilerplate to the top of the function?
> 
>    SealHandleScope shs(isolate);
>    DCHECK(args.length() == 0);

Done.

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h#n...
src/runtime/runtime.h:729: #define FOR_EACH_INTRINSIC_IC(F)             \
On 2015/07/23 at 11:36:15, Michael Starzinger wrote:
> nit: Can we add a short one-line comment saying that those runtime function
are actually implemented in "ic.cc" file outside of the "runtime" directory?

Done

[danno, 2015-07-23 11:51:53]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-23 11:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1248303002/#ps80001
(title: "Review feedback")

[commit-bot: I haz the power, 2015-07-23 11:52:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248303002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1248303002/80001

[danno, 2015-07-23 11:55:40]

The CQ bit was unchecked by danno@chromium.org

[Yang, 2015-07-23 12:00:50]

LGTM with a nit.

https://codereview.chromium.org/1248303002/diff/80001/src/arm64/code-stubs-ar...
File src/arm64/code-stubs-arm64.cc (right):

https://codereview.chromium.org/1248303002/diff/80001/src/arm64/code-stubs-ar...
src/arm64/code-stubs-arm64.cc:2059: __ TailCallExternalReference(
Maybe use TailCallRuntime instead.

[danno, 2015-07-23 13:15:42]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-23 13:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1248303002/#ps120001
(title: "Make mips work")

[commit-bot: I haz the power, 2015-07-23 13:15:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248303002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1248303002/120001

[commit-bot: I haz the power, 2015-07-23 13:32:18]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-23 13:32:37]

Patchset 7 (id:??) landed as
https://crrev.com/bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e
Cr-Commit-Position: refs/heads/master@{#29811}