Unify runtime-style IC functions with Runtime intrinsics

src/arm64/code-stubs-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
@@ skipping 2038 matching lines @@
   Label slow;
 
   Register receiver = LoadDescriptor::ReceiverRegister();
   Register key = LoadDescriptor::NameRegister();
 
   // Check that the key is an array index, that is Uint32.
   __ TestAndBranchIfAnySet(key, kSmiTagMask | kSmiSignMask, &slow);
 
   // Everything is fine, call runtime.
   __ Push(receiver, key);
   __ TailCallExternalReference(

[Yang, 2015/07/23 12:00:49]

Maybe use TailCallRuntime instead.

-      ExternalReference(IC_Utility(IC::kLoadElementWithInterceptor),
-                        masm->isolate()),
+      ExternalReference(
+          Runtime::FunctionForId(Runtime::kLoadElementWithInterceptor),
+          masm->isolate()),
       2, 1);
 
   __ Bind(&slow);
   PropertyAccessCompiler::TailCallBuiltin(
       masm, PropertyAccessCompiler::MissBuiltin(Code::KEYED_LOAD_IC));
 }
 
 
 void ArgumentsAccessStub::GenerateNewStrict(MacroAssembler* masm) {
   // Stack layout on entry.
@@ skipping 1226 matching lines @@
 
 void CallICStub::GenerateMiss(MacroAssembler* masm) {
   ASM_LOCATION("CallICStub[Miss]");
 
   FrameScope scope(masm, StackFrame::INTERNAL);
 
   // Push the receiver and the function and feedback info.
   __ Push(x1, x2, x3);
 
   // Call the entry.
-  IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
-                                             : IC::kCallIC_Customization_Miss;
+  Runtime::FunctionId id = GetICState() == DEFAULT
+                               ? Runtime::kCallIC_Miss
+                               : Runtime::kCallIC_Customization_Miss;
 
-  ExternalReference miss = ExternalReference(IC_Utility(id), masm->isolate());
+  ExternalReference miss =
+      ExternalReference(Runtime::FunctionForId(id), masm->isolate());
   __ CallExternalReference(miss, 3);
 
   // Move result to edi and exit the internal frame.
   __ Mov(x1, x0);
 }
 
 
 void StringCharCodeAtGenerator::GenerateFast(MacroAssembler* masm) {
   // If the receiver is a smi trigger the non-string case.
   if (check_mode_ == RECEIVER_IS_UNKNOWN) {
@@ skipping 421 matching lines @@
 
 // This method handles the case where a compare stub had the wrong
 // implementation. It calls a miss handler, which re-writes the stub. All other
 // CompareICStub::Generate* methods should fall back into this one if their
 // operands were not the expected types.
 void CompareICStub::GenerateMiss(MacroAssembler* masm) {
   ASM_LOCATION("CompareICStub[Miss]");
 
   Register stub_entry = x11;
   {
-    ExternalReference miss =
-      ExternalReference(IC_Utility(IC::kCompareIC_Miss), isolate());
+    ExternalReference miss = ExternalReference(
+        Runtime::FunctionForId(Runtime::kCompareIC_Miss), isolate());
 
     FrameScope scope(masm, StackFrame::INTERNAL);
     Register op = x10;
     Register left = x1;
     Register right = x0;
     // Preserve some caller-saved registers.
     __ Push(x1, x0, lr);
     // Push the arguments.
     __ Mov(op, Smi::FromInt(this->op()));
     __ Push(left, right, op);
@@ skipping 2068 matching lines @@
                            MemOperand(fp, 6 * kPointerSize), NULL);
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM64