Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc

Issue 12477009: With browser instant extended enabled, signing in should redirect to chrome://apps instead of to NT… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a new SyncPromoUI::Source for Apps page signin. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
index 1b49c0caa830a58becd2aa8007db38d114b185ba..14517a71d59b5e43335e67acb72a58f2f8457d08 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
@@ -29,6 +29,8 @@ enum {
UMA_WEBSTORE_INSTALL_SIGNED_IN,
UMA_APP_LAUNCHER_SHOWN,
UMA_APP_LAUNCHER_SIGNED_IN,
+ UMA_APPS_PAGE_LINK_SHOWN,
+ UMA_APPS_PAGE_LINK_SIGNED_IN,
UMA_MAX,
};
@@ -62,6 +64,9 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_APP_LAUNCHER:
uma = UMA_APP_LAUNCHER_SHOWN;
break;
+ case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
+ uma = UMA_APPS_PAGE_LINK_SHOWN;
+ break;
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SHOWN;
break;
@@ -69,7 +74,7 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
// If this assert hits, then the SyncPromoUI::Source enum has changed and
// the UMA enum above, this switch statement and histograms.xml all need
// to be updated to reflect that.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 7,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;
@@ -103,12 +108,15 @@ void RecordUserSignedIn(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_APP_LAUNCHER:
uma = UMA_APP_LAUNCHER_SIGNED_IN;
break;
+ case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
+ uma = UMA_APPS_PAGE_LINK_SIGNED_IN;
+ break;
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SIGNED_IN;
break;
default:
// This switch statement needs to be updated when the enum Source changes.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 7,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698