Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc

Issue 12477009: With browser instant extended enabled, signing in should redirect to chrome://apps instead of to NT… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a new SyncPromoUI::Source for Apps page signin. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/browser/ui/webui/ntp/ntp_login_handler.cc ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/sync_promo/sync_promo_trial.h" 5 #include "chrome/browser/ui/webui/sync_promo/sync_promo_trial.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/metrics/metrics_service.h" 8 #include "chrome/browser/metrics/metrics_service.h"
9 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h" 9 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
(...skipping 11 matching lines...) Expand all
22 UMA_SETTINGS_SHOWN, 22 UMA_SETTINGS_SHOWN,
23 UMA_SETTINGS_SIGNED_IN, 23 UMA_SETTINGS_SIGNED_IN,
24 UMA_EXTENSION_INSTALL_BUBBLE_SHOWN, 24 UMA_EXTENSION_INSTALL_BUBBLE_SHOWN,
25 UMA_EXTENSION_INSTALL_BUBBLE_SIGNED_IN, 25 UMA_EXTENSION_INSTALL_BUBBLE_SIGNED_IN,
26 UMA_UNKNOWN_SHOWN, 26 UMA_UNKNOWN_SHOWN,
27 UMA_UNKNOWN_SIGNED_IN, 27 UMA_UNKNOWN_SIGNED_IN,
28 UMA_WEBSTORE_INSTALL_SHOWN, 28 UMA_WEBSTORE_INSTALL_SHOWN,
29 UMA_WEBSTORE_INSTALL_SIGNED_IN, 29 UMA_WEBSTORE_INSTALL_SIGNED_IN,
30 UMA_APP_LAUNCHER_SHOWN, 30 UMA_APP_LAUNCHER_SHOWN,
31 UMA_APP_LAUNCHER_SIGNED_IN, 31 UMA_APP_LAUNCHER_SIGNED_IN,
32 UMA_APPS_PAGE_LINK_SHOWN,
33 UMA_APPS_PAGE_LINK_SIGNED_IN,
32 UMA_MAX, 34 UMA_MAX,
33 }; 35 };
34 36
35 } // namespace 37 } // namespace
36 38
37 namespace sync_promo_trial { 39 namespace sync_promo_trial {
38 40
39 void RecordUserShownPromo(content::WebUI* web_ui) { 41 void RecordUserShownPromo(content::WebUI* web_ui) {
40 SyncPromoUI::Source source = SyncPromoUI::GetSourceForSyncPromoURL( 42 SyncPromoUI::Source source = SyncPromoUI::GetSourceForSyncPromoURL(
41 web_ui->GetWebContents()->GetURL()); 43 web_ui->GetWebContents()->GetURL());
(...skipping 13 matching lines...) Expand all
55 break; 57 break;
56 case SyncPromoUI::SOURCE_EXTENSION_INSTALL_BUBBLE: 58 case SyncPromoUI::SOURCE_EXTENSION_INSTALL_BUBBLE:
57 uma = UMA_EXTENSION_INSTALL_BUBBLE_SHOWN; 59 uma = UMA_EXTENSION_INSTALL_BUBBLE_SHOWN;
58 break; 60 break;
59 case SyncPromoUI::SOURCE_WEBSTORE_INSTALL: 61 case SyncPromoUI::SOURCE_WEBSTORE_INSTALL:
60 uma = UMA_WEBSTORE_INSTALL_SHOWN; 62 uma = UMA_WEBSTORE_INSTALL_SHOWN;
61 break; 63 break;
62 case SyncPromoUI::SOURCE_APP_LAUNCHER: 64 case SyncPromoUI::SOURCE_APP_LAUNCHER:
63 uma = UMA_APP_LAUNCHER_SHOWN; 65 uma = UMA_APP_LAUNCHER_SHOWN;
64 break; 66 break;
67 case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
68 uma = UMA_APPS_PAGE_LINK_SHOWN;
69 break;
65 case SyncPromoUI::SOURCE_UNKNOWN: 70 case SyncPromoUI::SOURCE_UNKNOWN:
66 uma = UMA_UNKNOWN_SHOWN; 71 uma = UMA_UNKNOWN_SHOWN;
67 break; 72 break;
68 default: 73 default:
69 // If this assert hits, then the SyncPromoUI::Source enum has changed and 74 // If this assert hits, then the SyncPromoUI::Source enum has changed and
70 // the UMA enum above, this switch statement and histograms.xml all need 75 // the UMA enum above, this switch statement and histograms.xml all need
71 // to be updated to reflect that. 76 // to be updated to reflect that.
72 COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 7, 77 COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
73 kSourceEnumHasChangedButNotThisSwitchStatement); 78 kSourceEnumHasChangedButNotThisSwitchStatement);
74 NOTREACHED(); 79 NOTREACHED();
75 break; 80 break;
76 } 81 }
77 UMA_HISTOGRAM_ENUMERATION("SyncPromo.ShowAndSignIn", uma, UMA_MAX); 82 UMA_HISTOGRAM_ENUMERATION("SyncPromo.ShowAndSignIn", uma, UMA_MAX);
78 } 83 }
79 84
80 void RecordUserSignedIn(content::WebUI* web_ui) { 85 void RecordUserSignedIn(content::WebUI* web_ui) {
81 SyncPromoUI::Source source = SyncPromoUI::GetSourceForSyncPromoURL( 86 SyncPromoUI::Source source = SyncPromoUI::GetSourceForSyncPromoURL(
82 web_ui->GetWebContents()->GetURL()); 87 web_ui->GetWebContents()->GetURL());
(...skipping 13 matching lines...) Expand all
96 break; 101 break;
97 case SyncPromoUI::SOURCE_EXTENSION_INSTALL_BUBBLE: 102 case SyncPromoUI::SOURCE_EXTENSION_INSTALL_BUBBLE:
98 uma = UMA_EXTENSION_INSTALL_BUBBLE_SIGNED_IN; 103 uma = UMA_EXTENSION_INSTALL_BUBBLE_SIGNED_IN;
99 break; 104 break;
100 case SyncPromoUI::SOURCE_WEBSTORE_INSTALL: 105 case SyncPromoUI::SOURCE_WEBSTORE_INSTALL:
101 uma = UMA_WEBSTORE_INSTALL_SIGNED_IN; 106 uma = UMA_WEBSTORE_INSTALL_SIGNED_IN;
102 break; 107 break;
103 case SyncPromoUI::SOURCE_APP_LAUNCHER: 108 case SyncPromoUI::SOURCE_APP_LAUNCHER:
104 uma = UMA_APP_LAUNCHER_SIGNED_IN; 109 uma = UMA_APP_LAUNCHER_SIGNED_IN;
105 break; 110 break;
111 case SyncPromoUI::SOURCE_APPS_PAGE_LINK:
112 uma = UMA_APPS_PAGE_LINK_SIGNED_IN;
113 break;
106 case SyncPromoUI::SOURCE_UNKNOWN: 114 case SyncPromoUI::SOURCE_UNKNOWN:
107 uma = UMA_UNKNOWN_SIGNED_IN; 115 uma = UMA_UNKNOWN_SIGNED_IN;
108 break; 116 break;
109 default: 117 default:
110 // This switch statement needs to be updated when the enum Source changes. 118 // This switch statement needs to be updated when the enum Source changes.
111 COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 7, 119 COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 8,
112 kSourceEnumHasChangedButNotThisSwitchStatement); 120 kSourceEnumHasChangedButNotThisSwitchStatement);
113 NOTREACHED(); 121 NOTREACHED();
114 break; 122 break;
115 } 123 }
116 UMA_HISTOGRAM_ENUMERATION("SyncPromo.ShowAndSignIn", uma, UMA_MAX); 124 UMA_HISTOGRAM_ENUMERATION("SyncPromo.ShowAndSignIn", uma, UMA_MAX);
117 } 125 }
118 126
119 } // namespace sync_promo_trial 127 } // namespace sync_promo_trial
OLDNEW
« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/browser/ui/webui/ntp/ntp_login_handler.cc ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698