chrome/browser/ui/webui/ntp/ntp_login_handler.cc - Issue 12477009: With browser instant extended enabled, signing in should redirect to chrome://apps instead of to NT…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_login_handler.cc

Issue 12477009: With browser instant extended enabled, signing in should redirect to chrome://apps instead of to NT… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a new SyncPromoUI::Source for Apps page signin. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_login_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

index c5f260b1f2a0a6614d98beecb1da73467b73f8d2..73fd45b1969281f1e872aeb0ca31e0997d340bde 100644

--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

+++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

@@ -142,7 +142,10 @@ void NTPLoginHandler::HandleShowSyncLoginUI(const ListValue* args) {

#if !defined(OS_ANDROID)

// The user isn't signed in, show the sync promo.

if (SyncPromoUI::ShouldShowSyncPromo(profile)) {

- chrome::ShowBrowserSignin(browser, SyncPromoUI::SOURCE_NTP_LINK);

+ SyncPromoUI::Source source =

+ (web_contents->GetURL().spec() == chrome::kChromeUIAppsURL) ?

+ SyncPromoUI::SOURCE_APPS_PAGE_LINK : SyncPromoUI::SOURCE_NTP_LINK;

+ chrome::ShowBrowserSignin(browser, source);

RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);

}

#endif