Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 124733002: [Telemetry] Support downloading profiles from cloud storage (Closed)

Created:
6 years, 11 months ago by jeremy
Modified:
6 years, 11 months ago
Reviewers:
aberent, dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, telemetry+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

[Telemetry] Support download profiles from cloud storage Needed for theme and many extension startup tests. * Add benchmarks/startup_with_extensions.py - new theme and many_profile startup tests. * Teach test.py to use .sha1 files for profile directories, these are downloaded from cloud storage, unzipped and then used as the profile directory by the browser. * Add a function to browser_finder to allow querying the target OS. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243543

Patch Set 1 #

Patch Set 2 : Whitespace fixes #

Total comments: 5

Patch Set 3 : Add PossibleBrowser.target_os #

Patch Set 4 : Remove stale function #

Patch Set 5 : Rebased #

Patch Set 6 : Don't cache FindBrowser results since it breaks unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -5 lines) Patch
M tools/perf/benchmarks/startup.py View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tools/perf/generated_profiles/darwin/many_extensions_profile.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/generated_profiles/darwin/theme_profile.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/generated_profiles/linux/many_extensions_profile.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/generated_profiles/linux/theme_profile.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/possible_browser.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/test.py View 1 2 3 4 3 chunks +71 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jeremy
tonyg/dtu: review aberent: WDYT about TargetBrowserOS()? https://codereview.chromium.org/124733002/diff/20001/tools/perf/generated_profiles/darwin/many_extensions_profile.zip.sha1 File tools/perf/generated_profiles/darwin/many_extensions_profile.zip.sha1 (right): https://codereview.chromium.org/124733002/diff/20001/tools/perf/generated_profiles/darwin/many_extensions_profile.zip.sha1#newcode1 tools/perf/generated_profiles/darwin/many_extensions_profile.zip.sha1:1: 87f83fecf7b0838cf5f492e1977f6b32ef4b6a71 Is there ...
6 years, 11 months ago (2014-01-06 06:57:07 UTC) #1
aberent
https://codereview.chromium.org/124733002/diff/20001/tools/telemetry/telemetry/core/browser_finder.py File tools/telemetry/telemetry/core/browser_finder.py (right): https://codereview.chromium.org/124733002/diff/20001/tools/telemetry/telemetry/core/browser_finder.py#newcode34 tools/telemetry/telemetry/core/browser_finder.py:34: def TargetBrowserOS(options): On 2014/01/06 06:57:07, jeremy wrote: > Guessing ...
6 years, 11 months ago (2014-01-06 10:44:52 UTC) #2
jeremy
Tony/dtu: rest of CL is still reviewable, thanks! https://codereview.chromium.org/124733002/diff/20001/tools/telemetry/telemetry/core/browser_finder.py File tools/telemetry/telemetry/core/browser_finder.py (right): https://codereview.chromium.org/124733002/diff/20001/tools/telemetry/telemetry/core/browser_finder.py#newcode34 tools/telemetry/telemetry/core/browser_finder.py:34: def ...
6 years, 11 months ago (2014-01-06 11:23:57 UTC) #3
tonyg
lgtm when aberent is happy https://codereview.chromium.org/124733002/diff/20001/tools/perf/benchmarks/startup_with_extensions.py File tools/perf/benchmarks/startup_with_extensions.py (right): https://codereview.chromium.org/124733002/diff/20001/tools/perf/benchmarks/startup_with_extensions.py#newcode9 tools/perf/benchmarks/startup_with_extensions.py:9: class StartupColdTheme(test.Test): I recommend ...
6 years, 11 months ago (2014-01-06 18:53:55 UTC) #4
jeremy
aberent: all fixed, ready for another look :)
6 years, 11 months ago (2014-01-07 15:52:13 UTC) #5
aberent
lgtm
6 years, 11 months ago (2014-01-07 17:47:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/124733002/190001
6 years, 11 months ago (2014-01-08 08:23:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=209041
6 years, 11 months ago (2014-01-08 09:18:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/124733002/530001
6 years, 11 months ago (2014-01-08 10:21:00 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 12:58:20 UTC) #10
Message was sent while issue was closed.
Change committed as 243543

Powered by Google App Engine
This is Rietveld 408576698